Alon Bar-Lev has posted comments on this change. Change subject: aaa: Changes to ExtensionsManager ......................................................................
Patch Set 19: (4 comments) http://gerrit.ovirt.org/#/c/27785/19/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java: Line 131 Line 132 Line 133 Line 134 Line 135 > what are you refering to exactly? which function? getTraceLog I would return here the traceLog.getName() or something similar, so our tracelog is the entity. Line 158 Line 159 Line 160 Line 161 Line 162 > You mean the binding loaders? change the bindingLoaders to static map? yes Line 271: throw new RuntimeException(String.format("No extensioned with instance name %1$s could be found", Line 272: extensionName)); Line 273: } Line 274: if (entry.enabled) { Line 275: entry.extension.getContext().put( > You mean only setting the TRACE_LOG, right? because we should also trace the load? Line 276: TRACE_LOG_CONTEXT_KEY, Line 277: LogFactory.getLog( Line 278: String.format( Line 279: "%1$s.%2$s.%3$s", Line 317: entry.extension.getExtension() Line 318: ).mput( Line 319: Base.ExtensionRecord.CONTEXT, Line 320: entry.extension.getContext() Line 321: ) > i agree about the global context. add extension status to global context as own field. Line 322: ); Line 323: } Line 324: entry.activated = true; Line 325: dumpConfig(entry.extension); -- To view, visit http://gerrit.ovirt.org/27785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c914df29a0dbf52ff6d2f8149687b31b4faffe1 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
