Simone Tiraboschi has posted comments on this change.

Change subject: WebSocketProxy on a separate host
......................................................................


Patch Set 29:

Hi Alon,
I agree with you that this patches gives two results:
- it makes the engine optional
- it helps the user to automatically create a setup where the websocketproxy 
and the egine are on two different hosts

we can also split it into two distinct patches but the first by itself it not 
so useful cause you can simply runs engine-setup without installing the engine 
and by itself it's not so useful.

By the way, with this patch, if the user says that he don't want to install the 
engine but the engine rpms are in place, engine-setup simply aborts alerting 
the user to remove unneeded rpms.
I added it just to prevent the case where a user want to install websocket 
proxy on a separate host but he installed the engine rpms also on the second 
host with the result of having two distinct engine on the two hosts and just a 
websocketproxy on one of them and a lot of confusion.

Cause I also don't want to add an additional CA just to self-sign the websocket 
proxy, I'm generating it on the engine host and than on the second host I'm 
just coping it from the first via scp.
Cause I need also to download the websocket proxy private key, I don't see any 
other way to securely download it in an automated way.
We can simply let the user copy them via scp but it not so different.

-- 
To view, visit http://gerrit.ovirt.org/26898
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169604429e5a2d72573b05c0e5481306edfdd935
Gerrit-PatchSet: 29
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Lev Veyde <lve...@gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to