Simone Tiraboschi has posted comments on this change. Change subject: WebSocketProxy on a separate host ......................................................................
Patch Set 29: (1 comment) http://gerrit.ovirt.org/#/c/26898/29/packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py File packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py: Line 139: default=22, Line 140: ) Line 141: transport = None Line 142: try: Line 143: transport = paramiko.Transport( > this is incorrect sequence. I agree with you that an enrollment process like SCEP it's a better way to do it but on my opinion it's by far more complex. On the other side I'm just asking to user right the same information he'll give me via engine-config: the address of the websocketproxy or the address of the load balancer if he have once between them, it's really the same. So, if I know that I need this information, isn't simpler to ask him about it instead of alerting him to use another tool (engine-config) to give me the same information? Line 144: ( Line 145: self.environment[ Line 146: osetupcons.ConfigEnv.REMOTE_ENGINE_HOST Line 147: ], -- To view, visit http://gerrit.ovirt.org/26898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I169604429e5a2d72573b05c0e5481306edfdd935 Gerrit-PatchSet: 29 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
