Sandro Bonazzola has posted comments on this change. Change subject: WebSocketProxy on a separate host ......................................................................
Patch Set 27: (2 comments) http://gerrit.ovirt.org/#/c/26898/27/packaging/setup/plugins/ovirt-engine-remove/base/core/misc.py File packaging/setup/plugins/ovirt-engine-remove/base/core/misc.py: Line 73: ) Line 74: self.environment.setdefault( Line 75: osetupcons.RemoveEnv.FILES_TO_REMOVE, Line 76: [] Line 77: ) This is initialized by ovirt-engine-remove/ovirt-engine/files/simple.py Here is not used at all so I don't think you should initialize here this. I guess you should move simple.py plugin to a common place for reusing it on websocket proxy host. Line 78: Line 79: @plugin.event( Line 80: stage=plugin.Stages.STAGE_SETUP, Line 81: ) http://gerrit.ovirt.org/#/c/26898/27/packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/files/simple.py File packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/files/simple.py: Line 121 Line 122 Line 123 Line 124 Line 125 This shouldn't be removed. the whole simple plugin should be moved to a common place if you need this. -- To view, visit http://gerrit.ovirt.org/26898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I169604429e5a2d72573b05c0e5481306edfdd935 Gerrit-PatchSet: 27 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
