Alon Bar-Lev has posted comments on this change.

Change subject: WebSocketProxy on a separate host
......................................................................


Patch Set 29:

(1 comment)

http://gerrit.ovirt.org/#/c/26898/29/packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py
File packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py:

Line 139:                     default=22,
Line 140:                 )
Line 141:             transport = None
Line 142:             try:
Line 143:                 transport = paramiko.Transport(
> This patch does it that way: I'm not saying that it is the best on the only
this is incorrect sequence.

there can be as many as 10000000 proxies after load balancer.

in the remote sequence you simply do not ask anything at engine side.

you install websocket proxy on different machine and use engine-config at 
engine to instruct where it is.
Line 144:                     (
Line 145:                         self.environment[
Line 146:                             osetupcons.ConfigEnv.REMOTE_ENGINE_HOST
Line 147:                         ],


-- 
To view, visit http://gerrit.ovirt.org/26898
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169604429e5a2d72573b05c0e5481306edfdd935
Gerrit-PatchSet: 29
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Lev Veyde <lve...@gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to