Alon Bar-Lev has posted comments on this change. Change subject: aaa: Changing singletons to beans ......................................................................
Patch Set 11: (4 comments) rename bean names to something unique within the ovirt namespace? http://gerrit.ovirt.org/#/c/27348/11/backend/manager/modules/aaa/src/main/modules/org/ovirt/engine/core/aaa/main/module.xml File backend/manager/modules/aaa/src/main/modules/org/ovirt/engine/core/aaa/main/module.xml: Line 6: <resource-root path="aaa.jar"/> Line 7: </resources> Line 8: Line 9: <dependencies> Line 10: <module name="org.ovirt.engine.core.utils"/> sort? Line 11: <module name="javax.api"/> Line 12: <module name="javax.servlet.api"/> Line 13: <module name="org.apache.commons.lang"/> Line 14: <module name="org.ovirt.engine.core.common"/> http://gerrit.ovirt.org/#/c/27348/11/backend/manager/modules/extensions-manager/pom.xml File backend/manager/modules/extensions-manager/pom.xml: Line 11: <version>3.5.0-SNAPSHOT</version> Line 12: </parent> Line 13: Line 14: <artifactId>extensions-manager</artifactId> Line 15: <packaging>ejb</packaging> will components such as notifier will be able to load this jar? Line 16: Line 17: <name>Extensions manager</name> Line 18: Line 19: <dependencies> http://gerrit.ovirt.org/#/c/27348/11/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionProxy.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionProxy.java: Line 11: private Extension proxied; Line 12: private ExtMap context; Line 13: Line 14: private void dumpMap(String prefix, ExtMap map) { Line 15: Logger logger = context.<Logger> get(ExtensionsManager.TRACE_LOG_CONTEXT_KEY); not part of this patch Line 16: if (logger.isDebugEnabled()) { Line 17: logger.debug(prefix + " BEGIN"); Line 18: logger.debug(map.toString()); Line 19: logger.debug(prefix + " END"); http://gerrit.ovirt.org/#/c/27348/11/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java: Line 40: Logger.class, Line 41: "863db666-3ea7-4751-9695-918a3197ad83"); Line 42: public static final ExtKey CAUSE_OUTPUT_KEY = new ExtKey("EXTENSION_MANAGER_CAUSE_OUTPUT_KEY", Line 43: Throwable.class, Line 44: "894e1c86-518b-40a2-a92b-29ea1eb0403d"); all these not part of this patch Line 45: Line 46: private static interface BindingsLoader { Line 47: Extension load(Properties props) throws Exception; Line 48: } -- To view, visit http://gerrit.ovirt.org/27348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae3eeb7a487d58f59c4e75e3bf31ed10ac774142 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
