Alon Bar-Lev has posted comments on this change. Change subject: aaa: Changing singletons to beans ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/27348/9/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManagerBean.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManagerBean.java: Line 16: /** Line 17: * This class is responsible for loading the required {@code Configuration} in order to create an extension. It holds Line 18: * the logic of ordering and solving conflicts during loading the configuration Line 19: */ Line 20: @Singleton(name = "ExtensionsManager") consider ovirt.enigne.....ExtensionsManager to be unique within jvm? same for all singletons? Line 21: @Startup Line 22: @ConcurrencyManagement(ConcurrencyManagementType.BEAN) Line 23: public class ExtensionsManagerBean implements ExtensionsManagerLocal { Line 24: -- To view, visit http://gerrit.ovirt.org/27348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae3eeb7a487d58f59c4e75e3bf31ed10ac774142 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
