Alon Bar-Lev has posted comments on this change. Change subject: aaa: Changing singletons to beans ......................................................................
Patch Set 9: (6 comments) http://gerrit.ovirt.org/#/c/27348/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java: Line 113: authConfig.put(Base.ConfigKeys.PROVIDES, Authn.class.getName()); Line 114: authConfig.put(Base.ConfigKeys.BINDINGS_METHOD, Base.ConfigBindingsMethods.JBOSSMODULE); Line 115: authConfig.put(Base.ConfigKeys.BINDINGS_JBOSSMODULE_MODULE, "org.ovirt.engine.extensions.builtin"); Line 116: authConfig.put(Base.ConfigKeys.BINDINGS_JBOSSMODULE_CLASS, Line 117: "org.ovirt.engine.extensions.aaa.builtin.internal.InternalAuthn"); style changes in different patch Line 118: authConfig.put("ovirt.engine.aaa.authn.profile.name", "internal"); Line 119: authConfig.put("ovirt.engine.aaa.authn.authz.plugin", "internal"); Line 120: authConfig.put("config.authn.user.name", Config.<String> getValue(ConfigValues.AdminUser)); Line 121: authConfig.put("config.authn.user.password", Config.<String> getValue(ConfigValues.AdminPassword)); Line 127: dirConfig.put(Base.ConfigKeys.PROVIDES, Authz.class.getName()); Line 128: dirConfig.put(Base.ConfigKeys.BINDINGS_METHOD, Base.ConfigBindingsMethods.JBOSSMODULE); Line 129: dirConfig.put(Base.ConfigKeys.BINDINGS_JBOSSMODULE_MODULE, "org.ovirt.engine.extensions.builtin"); Line 130: dirConfig.put(Base.ConfigKeys.BINDINGS_JBOSSMODULE_CLASS, Line 131: "org.ovirt.engine.extensions.aaa.builtin.internal.InternalAuthz"); style changes in different patch Line 132: dirConfig.put("config.authz.user.name", Config.<String> getValue(ConfigValues.AdminUser)); Line 133: dirConfig.put("config.authz.user.id", "fdfc627c-d875-11e0-90f0-83df133b58cc"); Line 134: dirConfig.put("config.query.filter.size", Line 135: Config.<Integer> getValue(ConfigValues.MaxLDAPQueryPartsNumber)); Line 140: Map<String, String> passwordChangeMsgPerDomain = new HashMap<>(); Line 141: Map<String, String> passwordChangeUrlPerDomain = new HashMap<>(); Line 142: String[] pairs = Config.<String> getValue(ConfigValues.ChangePasswordMsg).split(","); Line 143: for (String pair : pairs) { Line 144: // Split the pair in such a way that if the URL contains :, it will not be split to strings style changes in different patch Line 145: String[] pairParts = pair.split(":", 2); Line 146: if (pairParts.length >= 2) { Line 147: String decodedMsgOrUrl; Line 148: try { Line 192: return value == null ? "" : value; Line 193: } Line 194: Line 195: Line 196: style changes in different patch http://gerrit.ovirt.org/#/c/27348/9/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionProxy.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionProxy.java: Line 11: private Extension proxied; Line 12: private ExtMap context; Line 13: Line 14: private void dumpMap(String prefix, ExtMap map) { Line 15: Logger logger = context.<Logger> get(ExtensionsManager.TRACE_LOG_CONTEXT_KEY); style changes into other patch Line 16: if (logger.isDebugEnabled()) { Line 17: logger.debug(prefix + " BEGIN"); Line 18: logger.debug(map.toString()); Line 19: logger.debug(prefix + " END"); http://gerrit.ovirt.org/#/c/27348/9/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java: Line 40: Logger.class, Line 41: "863db666-3ea7-4751-9695-918a3197ad83"); Line 42: public static final ExtKey CAUSE_OUTPUT_KEY = new ExtKey("EXTENSION_MANAGER_CAUSE_OUTPUT_KEY", Line 43: Throwable.class, Line 44: "894e1c86-518b-40a2-a92b-29ea1eb0403d"); style changes into other patch Line 45: Line 46: private static interface BindingsLoader { Line 47: Extension load(Properties props) throws Exception; Line 48: } -- To view, visit http://gerrit.ovirt.org/27348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae3eeb7a487d58f59c4e75e3bf31ed10ac774142 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
