Yair Zaslavsky has posted comments on this change.

Change subject: aaa: Changing singletons to beans
......................................................................


Patch Set 9:

Regarding one of the previous comments -
Once again, if we care to deploy the bean on a remote machine, all parameters 
of methods must be Serializable, which brings us back to the issue of having as 
parameter ServletRequest and ServletResponse (that is, having them set as 
values in an ExtMap).
IMHO, Java EE Singleton is the technical mean to ensure we will indeed have a 
singleton, and it's other features (remote lookup) are not part of the 
requirement or design , and as I stated before, a bean can have a "local 
interface" and then it is not mandatory the parameters are serialized.

-- 
To view, visit http://gerrit.ovirt.org/27348
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae3eeb7a487d58f59c4e75e3bf31ed10ac774142
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to