Maor Lipchuk has posted comments on this change. Change subject: core: Connect Storage Pool on iSCSI update ......................................................................
Patch Set 4: @Serey This is related to the bug since ThreadUtil, which was used in the class, has thrown a new RunTimeException, so the exception we got from VDSM was swallowed by it and the user got an internal error. I can add to the commit message that the all the hosts will be connected in a single thread We could fix the ThreadUtil but that will cause a change in all its other usages. the alternative solution is to open threads in the class, but openning new threads out side the ThreadUtil is not recommended. Why we have to use multi thread for this operation? we are already using one thread in all the other scenarios. why it should be different then ConnectStorageDomain we do now? -- To view, visit http://gerrit.ovirt.org/27359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b125471920792d8bfaae2327e6aa757c378ef0e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
