Alon Bar-Lev has posted comments on this change. Change subject: core: integrate make into maven ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/25661/3/mavenmake/pom.xml File mavenmake/pom.xml: Line 36: </executions> Line 37: <configuration> Line 38: <executable>make</executable> Line 39: <!-- for some reason it refuses to work with argument -C ${project.parent.basedir} --> Line 40: <workingDirectory>${project.parent.basedir}</workingDirectory> please do -C instead... should be very simple, just add argument -C and put the basedir as another argument. Line 41: <arguments> Line 42: <argument>install-dev</argument> Line 43: <argument>PREFIX=${prefix}</argument> Line 44: <argument>DEV_REBUILD=0</argument> -- To view, visit http://gerrit.ovirt.org/25661 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8981f04b26a2d36429f8bfccaada8dfbadfbf9c3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
