Alon Bar-Lev has posted comments on this change. Change subject: core: integrate make into maven ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25661/2/mavenmake/pom.xml File mavenmake/pom.xml: Line 44: <arguments> Line 45: <argument>install-dev</argument> Line 46: <argument>PREFIX=${devenv.prefix}</argument> Line 47: <argument>DEV_REBUILD=0</argument> Line 48: </arguments> > the mvn invoked by the make doesn't do the hard work. its the invoking mvn ok... I was confused with <devenv.prefix>${env.PREFIX}</devenv.prefix> in which you get PREFIX env and put it in devenv.prefix. I think that PREFIX should be renamed to something with something like OVIRT_ENGINE_PREFIX to be unique and enable user to put it in his .profile. thanks! Line 49: </configuration> Line 50: </plugin> Line 51: </plugins> Line 52: </build> -- To view, visit http://gerrit.ovirt.org/25661 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8981f04b26a2d36429f8bfccaada8dfbadfbf9c3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
