Alon Bar-Lev has posted comments on this change. Change subject: core: integrate make into maven ......................................................................
Patch Set 4: > what is MVN=true for? so that true is executed instead of mvn. this will make sure that the make will not build anything. without this, if tmp.built is missing maven is executed. so... git clean -dxf and attempt to use this will actually build using maven twice, one is the maven you are using and the other is make executing maven as tmp.built is missing. maven is not well behaved, there is no way to know if it completed build or not in the past... so we must use some signature. -- To view, visit http://gerrit.ovirt.org/25661 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8981f04b26a2d36429f8bfccaada8dfbadfbf9c3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
