Roy Golan has posted comments on this change. Change subject: core: integrate make into maven ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25661/2/mavenmake/pom.xml File mavenmake/pom.xml: Line 44: <arguments> Line 45: <argument>install-dev</argument> Line 46: <argument>PREFIX=${devenv.prefix}</argument> Line 47: <argument>DEV_REBUILD=0</argument> Line 48: </arguments> > good idea, should be also via environment as devenv.prefix. the mvn invoked by the make doesn't do the hard work. its the invoking mvn which actually build the whole thing so I think there is no value really to it mvn clean install -Pgwtdraft,make -Dgwt.compiler.localWorkers=2 -Ddevenv.prefix=/myPrefix Line 49: </configuration> Line 50: </plugin> Line 51: </plugins> Line 52: </build> -- To view, visit http://gerrit.ovirt.org/25661 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8981f04b26a2d36429f8bfccaada8dfbadfbf9c3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
