Yair Zaslavsky has posted comments on this change. Change subject: AAA: Introduce usage of Acct ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/27070/3/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationFilter.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationFilter.java: Line 165: break; Line 166: Line 167: default: Line 168: moveToNextProfile(session, stack); Line 169: AcctUtils.reportAuthRecord(Acct.ReportReason.PRINCIPAL_LOGIN_FAILED, authRecord); > see above... ok, so just so i understand -we report only login failures on behalf of the user, that is - if he typed in wong password? what about if his password expired? where is the border? if you say timeout and configuration are not the fault of the user (and i agree) and should not be reported, why should i report for example on pasword expiration? becuse the user did not care to change his password on time? (so it's his fault, same as when he types wrong password). Line 170: log.error(String.format("An error has occurred during negotiation. Error code is %1$s", Line 171: output.<Integer> get(Authn.InvokeKeys.RESULT))); Line 172: Line 173: -- To view, visit http://gerrit.ovirt.org/27070 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief13d233d11b7ab32b328735b4f58ec7cffff567 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
