Alon Bar-Lev has posted comments on this change. Change subject: aaa: Introduce usage of Acct ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/27070/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java: Line 375: principal).mput( Line 376: Acct.PrincipalRecord.AUTH_RECORD, Line 377: result) Line 378: ) Line 379: ); this should probably sync with other signature of functions in AcctUtils... decide either you pass raw data or digested. Line 380: if (authResult != Authn.AuthResult.SUCCESS) { Line 381: log.infoFormat( Line 382: "Can't login user \"{0}\" with authentication profile \"{1}\" because the authentication failed.", Line 383: user, -- To view, visit http://gerrit.ovirt.org/27070 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief13d233d11b7ab32b328735b4f58ec7cffff567 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
