Yair Zaslavsky has posted comments on this change. Change subject: AAA: Introduce usage of Acct ......................................................................
Patch Set 3: (3 comments) I have asked Juan and Vojtech, If you try to send a request to the server with an expired session, the GUI will run its logout logic (i.e - present the user that a logout occurred due to session experiation). do you think it's enough? http://gerrit.ovirt.org/#/c/27070/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java: Line 251: @Override Line 252: public void run() { Line 253: AcctUtils.reportReason(Acct.ReportReason.SHUTDOWN); Line 254: } Line 255: })); > are you sure all classes are alive at this point? i consulted with Juan about this, I thought of using @PreDestory instead. Line 256: Line 257: AcctUtils.reportReason(Acct.ReportReason.STARTUP); Line 258: } Line 259: http://gerrit.ovirt.org/#/c/27070/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java: Line 359: if (reportReason == null) { Line 360: reportReason = Acct.ReportReason.PRINCIPAL_LOGIN_FAILED; Line 361: } Line 362: Line 363: AcctUtils.reportAuthRecord(reportReason, result); > you should also get principal from output map, if missing use the user of i what do you mean use the user of the input map? construct a prinicial from it? Line 364: if (authResult != Authn.AuthResult.SUCCESS) { Line 365: log.infoFormat( Line 366: "Can't login user \"{0}\" with authentication profile \"{1}\" because the authentication failed.", Line 367: user, http://gerrit.ovirt.org/#/c/27070/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/session/SessionDataContainer.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/session/SessionDataContainer.java: Line 30: private static final String PASSWORD_PARAMETER_NAME = "password"; Line 31: private static final String HARD_LIMIT_PARAMETER_NAME = "hard_limit"; Line 32: private static final String SOFT_LIMIT_PARAMETER_NAME = "soft_limit"; Line 33: Line 34: private static final String AUTH_RECORD_PARAMETER_NAME = null; > why null? why not as the above have static name? 1. mistake 2. i'll add. Line 35: Line 36: private static SessionDataContainer dataProviderInstance = new SessionDataContainer(); Line 37: Line 38: private SessionDataContainer() { -- To view, visit http://gerrit.ovirt.org/27070 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief13d233d11b7ab32b328735b4f58ec7cffff567 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
