Yair Zaslavsky has posted comments on this change. Change subject: AAA: Introduce usage of Acct ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/27070/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/session/SessionDataContainer.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/session/SessionDataContainer.java: Line 147 Line 148 Line 149 Line 150 Line 151 > so why not just use the removeSession(sessionid) method and avoid duplicate you will have ConcurrentModificationException. You cannot use map.remove during an iteration. i will fix the if according to your suggestion. http://gerrit.ovirt.org/#/c/27070/3/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthn.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthn.java: Line 41: output.put(Authn.InvokeKeys.RESULT, Authn.AuthResult.CREDENTIALS_INVALID); Line 42: } else { Line 43: output.put(Authn.InvokeKeys.RESULT, Authn.AuthResult.SUCCESS); Line 44: } Line 45: output.put(Authn.InvokeKeys.AUTH_RECORD, > auth record should be set only if success. Done Line 46: new ExtMap().mput( Line 47: Authn.AuthRecord.PRINCIPAL, Line 48: adminUser Line 49: ) http://gerrit.ovirt.org/#/c/27070/3/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapAuthenticateUserCommand.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapAuthenticateUserCommand.java: Line 32: new ExtMap().mput( Line 33: Authn.AuthRecord.PRINCIPAL, Line 34: loginName Line 35: )); Line 36: > auth record should be set only if success. Done Line 37: if (!loginName.contains("@")) { Line 38: loginName = loginName + "@" + getDomain(); Line 39: } Line 40: -- To view, visit http://gerrit.ovirt.org/27070 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief13d233d11b7ab32b328735b4f58ec7cffff567 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
