anmolbabu has posted comments on this change. Change subject: ui-plugin : Trends Tab ......................................................................
Patch Set 26: (7 comments) http://gerrit.ovirt.org/#/c/25471/26/gluster-nagios-dashboard/karma.conf.js File gluster-nagios-dashboard/karma.conf.js: Line 61: // - Opera (has to be installed with `npm install karma-opera-launcher`) Line 62: // - Safari (only Mac; has to be installed with `npm install karma-safari-launcher`) Line 63: // - PhantomJS Line 64: // - IE (only Windows; has to be installed with `npm install karma-ie-launcher`) Line 65: browsers: ['Chrome'], > Ya sorry I was just trying to test it on my system using chrome as firefox I removed it from my commit Line 66: Line 67: Line 68: // If browser does not capture in given timeout [ms], kill it Line 69: captureTimeout: 60000, http://gerrit.ovirt.org/#/c/25471/26/gluster-nagios-dashboard/src/js/dashboard-init.js File gluster-nagios-dashboard/src/js/dashboard-init.js: Line 14: pluginApi.addMainTab('Dashboard', 'dashboard-tab', urlUtil.relativeUrl('dashboard.html')); Line 15: } Line 16: if(pluginApi.configObject().ApplicationMode == "TrendsOnly" || pluginApi.configObject().ApplicationMode == "Both") { Line 17: pluginApi.addMainTab('Trends', 'trends-tab', urlUtil.relativeUrl('trendsTab.html')); Line 18: } > I feel showDashboard or showTrends provides more flexibility. Done Line 19: }, Line 20: setTabWindow: function (window) { Line 21: tabWindow = window; Line 22: }, Line 29: var entityId = selectedTreeItem.entity && selectedTreeItem.entity.id; Line 30: var entityName = selectedTreeItem.entity && selectedTreeItem.entity.name; Line 31: var entityClusterId = selectedTreeItem.entity && selectedTreeItem.entity.clusterId; Line 32: var configObject = pluginApi.configObject(); Line 33: //$window.alert("Code has data need to message it"); > Remove commented line Done Line 34: tabWindow.setTestData(type, entityId, entityName, entityClusterId, configObject); Line 35: } Line 36: } Line 37: }; http://gerrit.ovirt.org/#/c/25471/26/gluster-nagios-dashboard/src/trendsTab.html File gluster-nagios-dashboard/src/trendsTab.html: Line 5: <script src="lib/angular/js/angular.js"></script> Line 6: <script src="lib/ui-bootstrap-tpls-0.10.0.js"></script> Line 7: <script src="js/trends.js"></script> Line 8: <link href="lib/bootstrap/css/bootstrap.min.css" rel="stylesheet"> Line 9: <script src="js/common.js"></script> > move this line before the above line Done Line 10: </head> Line 11: <body ng-controller="tabController"> Line 12: <div id="header" style="width: 100%; height: 90px; background-color: #E6E6FA ; text-align:center"> Line 13: <div id="padding-left" style="width: 12%; float: left;visibility: hidden;">''</div> Line 14: <div id="startDateAndTime" ng-controller="startDateTimeController" style="float: left; width:30%;"> Line 15: <div style="width: 54%; padding-top: 37px; float: left;"> Line 16: <div> Line 17: <p class="input-group"> Line 18: <input type="text" class="form-control" datepicker-popup="{{format}}" ng-model="startdt" is-open="opened" max="max-date" datepicker-options="dateOptions" ng-required="true" close-text="Close" /> > Remove space Done Line 19: <span class="input-group-btn"> Line 20: <button class="btn btn-default" ng-click="open($event)"> Line 21: <i class="glyphicon glyphicon-calendar"></i> Line 22: </button> Line 55: <div style="width:2%;"></div> Line 56: <div id="graphActions" style="float: left; padding-top: 41px;width:10%;"> Line 57: <div> Line 58: <img src="images/refresh.png" style="height: 18px;" ng-click="refresh()"/> Line 59: <img src="images/print.png" style=" height: 22px;" ng-click="exportToPdf()"/> > remove space Done Line 60: </div> Line 61: </div> Line 62: </div> Line 63: <div align="center"> http://gerrit.ovirt.org/#/c/25471/26/gluster-nagios-dashboard/test/spec/dashboard-init-spec.js File gluster-nagios-dashboard/test/spec/dashboard-init-spec.js: Line 30: pluginApiMock.configObject = function() { Line 31: return config; Line 32: }; Line 33: pluginApiMock.options = function(obj) { Line 34: > Remove space Done Line 35: }; Line 36: inject(function ($injector){ Line 37: initService = $injector.get('initService'); Line 38: }); -- To view, visit http://gerrit.ovirt.org/25471 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7c00636e380da154f7f457066fe89475d04c9b4 Gerrit-PatchSet: 26 Gerrit-Project: samples-uiplugins Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
