anmolbabu has posted comments on this change. Change subject: ui-plugin : Trends Tab ......................................................................
Patch Set 30: (3 comments) http://gerrit.ovirt.org/#/c/25471/30/gluster-nagios-dashboard/gluster-nagios-dashboard.json File gluster-nagios-dashboard/gluster-nagios-dashboard.json: Line 2: "name": "GlusterNagiosDashboard", Line 3: "url": "plugin/GlusterNagiosDashboard/start.html", Line 4: "resourcePath": "gluster-nagios-resources", Line 5: "config": { Line 6: "showDashboard": "true", > If this option is not specified, should defaults to true. Done Line 7: "messageOrigins":["http://localhost.localdomain:8080";], Line 8: "pnp4nagiosUrl" : "http://10.70.43.162"; Line 9: } Line 3: "url": "plugin/GlusterNagiosDashboard/start.html", Line 4: "resourcePath": "gluster-nagios-resources", Line 5: "config": { Line 6: "showDashboard": "true", Line 7: "messageOrigins":["http://localhost.localdomain:8080";], > Keep this, but document it in README Done Line 8: "pnp4nagiosUrl" : "http://10.70.43.162"; Line 9: } Line 4: "resourcePath": "gluster-nagios-resources", Line 5: "config": { Line 6: "showDashboard": "true", Line 7: "messageOrigins":["http://localhost.localdomain:8080";], Line 8: "pnp4nagiosUrl" : "http://10.70.43.162"; > same as above Done Line 9: } -- To view, visit http://gerrit.ovirt.org/25471 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7c00636e380da154f7f457066fe89475d04c9b4 Gerrit-PatchSet: 30 Gerrit-Project: samples-uiplugins Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
