anmolbabu has posted comments on this change. Change subject: ui-plugin : Trends Tab ......................................................................
Patch Set 26: (2 comments) http://gerrit.ovirt.org/#/c/25471/26/gluster-nagios-dashboard/gluster-nagios-dashboard.json File gluster-nagios-dashboard/gluster-nagios-dashboard.json: Line 5: "config": { Line 6: "ApplicationMode": "1", Line 7: "messageOrigins":["http://localhost.localdomain:8080"; , "http://10.70.1.124:8080"; , "http://10.3.224.100:8080";] , Line 8: "pnp4nagiosUrl" : "http://10.3.12.50/pnp4nagios/image?";, Line 9: "ApplicationMode" : "TrendsOnly" > ApplicationMode is duplicate. Done Line 10: } http://gerrit.ovirt.org/#/c/25471/26/gluster-nagios-dashboard/karma.conf.js File gluster-nagios-dashboard/karma.conf.js: Line 61: // - Opera (has to be installed with `npm install karma-opera-launcher`) Line 62: // - Safari (only Mac; has to be installed with `npm install karma-safari-launcher`) Line 63: // - PhantomJS Line 64: // - IE (only Windows; has to be installed with `npm install karma-ie-launcher`) Line 65: browsers: ['Chrome'], > Firefox is what we support Ya sorry I was just trying to test it on my system using chrome as firefox was giving me some problems.Will remove this file from my commit. Line 66: Line 67: Line 68: // If browser does not capture in given timeout [ms], kill it Line 69: captureTimeout: 60000, -- To view, visit http://gerrit.ovirt.org/25471 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7c00636e380da154f7f457066fe89475d04c9b4 Gerrit-PatchSet: 26 Gerrit-Project: samples-uiplugins Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
