anmolbabu has posted comments on this change. Change subject: ui-plugin : Trends Tab ......................................................................
Patch Set 27: (5 comments) http://gerrit.ovirt.org/#/c/25471/27/gluster-nagios-dashboard/gluster-nagios-dashboard.json File gluster-nagios-dashboard/gluster-nagios-dashboard.json: Line 2: "name": "GlusterNagiosDashboard", Line 3: "url": "plugin/GlusterNagiosDashboard/start.html", Line 4: "resourcePath": "gluster-nagios-resources", Line 5: "config": { Line 6: "showDashboard": "false", > defaults to True Done Line 7: "messageOrigins":["http://localhost.localdomain:8080"; , "http://10.70.1.124:8080"; , "http://10.3.224.100:8080";] , Line 8: "pnp4nagiosUrl" : "http://10.3.12.50/pnp4nagios/image?"; Line 9: } Line 3: "url": "plugin/GlusterNagiosDashboard/start.html", Line 4: "resourcePath": "gluster-nagios-resources", Line 5: "config": { Line 6: "showDashboard": "false", Line 7: "messageOrigins":["http://localhost.localdomain:8080"; , "http://10.70.1.124:8080"; , "http://10.3.224.100:8080";] , > Do we need all of them? Done Line 8: "pnp4nagiosUrl" : "http://10.3.12.50/pnp4nagios/image?"; Line 9: } Line 4: "resourcePath": "gluster-nagios-resources", Line 5: "config": { Line 6: "showDashboard": "false", Line 7: "messageOrigins":["http://localhost.localdomain:8080"; , "http://10.70.1.124:8080"; , "http://10.3.224.100:8080";] , Line 8: "pnp4nagiosUrl" : "http://10.3.12.50/pnp4nagios/image?"; > i hope this is an optional one. If this property is not defined, nagios is Done Line 9: } http://gerrit.ovirt.org/#/c/25471/27/gluster-nagios-dashboard/src/trendsTab.html File gluster-nagios-dashboard/src/trendsTab.html: Line 18: } Line 19: @media print { Line 20: .noPrint { display:none;width: 100%;height: 150px;} Line 21: .printButDontShow {display: block;text-align: center;} Line 22: } > Move the styles to .css file Done Line 23: </style> Line 24: </head> Line 25: <body ng-controller="tabController"> Line 26: <div class="noPrint"> http://gerrit.ovirt.org/#/c/25471/27/gluster-nagios-dashboard/test/spec/dashboard-init-spec.js File gluster-nagios-dashboard/test/spec/dashboard-init-spec.js: Line 8: var eventHandlerObject; Line 9: var initService; Line 10: var config = { Line 11: url : "10.3.12.50/pnp4nagios", Line 12: ApplicationMode : "TrendsOnly", > This is no more applicable Done Line 13: messageOrigins : "localhost.localdomain:8080" Line 14: }; Line 15: var apiOptions = { Line 16: allowedMessageOrigins: config.messageOrigins -- To view, visit http://gerrit.ovirt.org/25471 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7c00636e380da154f7f457066fe89475d04c9b4 Gerrit-PatchSet: 27 Gerrit-Project: samples-uiplugins Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
