Daniel Erez has posted comments on this change.
Change subject: core: Grayed-Out LUNs Support
......................................................................
Patch Set 5: (4 inline comments)
....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/config.sql
Line 104: select fn_db_add_config_value('FilteringLUNsEnabled','true','2.2');
* True, but I still think it's better to save it as a config value rather than
some "3.1" constant both in the Backend and UI.
* I'll remove it if it's bothering...
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetDeviceListQuery.java
Line 30: getParameters().getVdsId(), getUserID(),
getParameters().isFiltered());
* I've declared 'GetDeviceListQuery' as a User query since it is in use also by
the power user portal [VdcQueryType -> GetDeviceList(VdcQueryAuthType.User)]
* The enforcing is not optional for the user portal - it sends
'isFiltered=true' by default. Hence, all entities are filtered according to the
user permissions.
* The webadmin sends 'isFiltered=false' for every query.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LUNs.java
Line 295: inUse = value;
* I've intended to use it also for DirectLUN disk indication.
* I can manage without it by filtering all existing DirectLUN disks.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommand.java
Line 33: if (!filteringLUNsEnabled) {
* Just thought it's redundant to send 'False' to 'GetDeviceList', since
'filteringLUNsEnabled=true' already implies dc<3.1.
* If we're deciding to waive ConfigValues.FilteringLUNsEnabled, I can just send
version<3.1
--
To view, visit http://gerrit.ovirt.org/4858
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia716e72c6caa097b42d8864ab23144149d360df2
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
