Allon Mureinik has posted comments on this change. Change subject: core: Grayed-Out LUNs Support ......................................................................
Patch Set 3: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetDeviceListQuery.java Line 42: // Filtering indication flag you should call getForVds(vdsId, getUserId(), getParameters().isFiltered()) If storage_pool is null, the query returns an empty list. See instrcutions in http://ovirt.org/wiki/Features/User_Portal_Permissions/Writing_A_New_User_Query for implementing the DAO. .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetDeviceListQueryTest.java Line 167: */ Forgot the abstract also has a @Before method... use this: @Override @Before public void setUp() { super.setUp(); // your code here... } -- To view, visit http://gerrit.ovirt.org/4858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia716e72c6caa097b42d8864ab23144149d360df2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
