Yair Zaslavsky has posted comments on this change. Change subject: aaa: Stopping to use proxies ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/26602/11/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutomaticLoginFilter.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutomaticLoginFilter.java: Line 104: ); Line 105: rsp.sendError(HttpServletResponse.SC_UNAUTHORIZED); Line 106: return; Line 107: } Line 108: // TODO: revisit this, as fetchPrincipalRecord is supposed to get authentication record Please advise here - not sure to tackle this. We said that I should use for fetchPrincipalRecord a record obtained from authn. How do I provide this record here? Line 109: // that was returned from authentication. Line 110: ExtMap authRecord = new ExtMap(); Line 111: DirectoryUser directoryUser = AuthzUtils.fetchPrincipalRecord(authz, authRecord); Line 112: if (directoryUser == null) { -- To view, visit http://gerrit.ovirt.org/26602 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I916012eab61a96bdb0f366d9dc8462325d7f726f Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
