Yair Zaslavsky has posted comments on this change. Change subject: aaa: Stopping to use proxies ......................................................................
Patch Set 9: (3 comments) http://gerrit.ovirt.org/#/c/26602/9/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java: Line 144: Line 145: public static List<DirectoryUser> findUsersByIds(final ExtensionProxy extension, final List<String> ids) { Line 146: return queryUsers(extension, Line 147: generateQuery(generateIdsListQuery(Authz.QueryEntity.PRINCIPAL, ids), Authz.QueryEntity.PRINCIPAL)); Line 148: } > it can be int, not sure why a new cast is required... I try to use long whe ok, we have Long.intValue() :) i used it. Line 149: Line 150: public static DirectoryUser findUserById(final ExtensionProxy extension, final String id) { Line 151: List<DirectoryUser> users = findUsersByIds(extension, Arrays.asList(id)); Line 152: if (users.isEmpty()) { http://gerrit.ovirt.org/#/c/26602/9/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthenticator.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthenticator.java: Line 87 Line 88 Line 89 Line 90 Line 91 > so you need to find http: or https: Done Line 66: context.mput( Line 67: Base.ContextKeys.AUTHOR, Line 68: "The oVirt Project").mput( Line 69: Base.ContextKeys.EXTENSION_NAME, Line 70: "Internal Authentication (Built-in)" > yes, better to drop these terms in favour of authz/authn or authentication/ Done Line 71: ).mput( Line 72: Base.ContextKeys.LICENSE, Line 73: "ASL 2.0" Line 74: ).mput( -- To view, visit http://gerrit.ovirt.org/26602 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I916012eab61a96bdb0f366d9dc8462325d7f726f Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
