Yair Zaslavsky has posted comments on this change.

Change subject: aaa: Stopping to  use proxies
......................................................................


Patch Set 11:

(1 comment)

http://gerrit.ovirt.org/#/c/26602/11/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthz.java
File 
backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthz.java:

Line 268:         if (filter == null) {
Line 269:             ExtKey key = queryFilterRecord.<ExtKey> 
get(Authz.QueryFilterRecord.KEY);
Line 270:             result.append(
Line 271:                     String.format(
Line 272:                             "%1$s=%2$s", keysToAttributes.get(key),
> why =?
Right, at the specific case this will always be =.
But ok, I'll fix to the general case.
Noted about the brackets.
Line 273:                             queryFilterRecord.get(key)
Line 274:                             )
Line 275:                     );
Line 276:         } else {


-- 
To view, visit http://gerrit.ovirt.org/26602
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I916012eab61a96bdb0f366d9dc8462325d7f726f
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to