Alon Bar-Lev has posted comments on this change. Change subject: aaa: Stopping to use proxies ......................................................................
Patch Set 10: (3 comments) http://gerrit.ovirt.org/#/c/26602/10/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java: Line 23: public ExtMap getCommandParameters(); Line 24: } Line 25: Line 26: private static final int QUERIES_RESULTS_LIMIT = 1000; Line 27: private static final long PAGE_SIZE = 100; > also at PAGE_SIZE? didn't we agree that page_size will be 100? we discussed that provider can return 100 even if you ask for 1000. Line 28: Line 29: Line 30: public static String getName(ExtensionProxy proxy) { Line 31: return proxy.getContext().<String> get(Base.ContextKeys.INSTANCE_NAME); Line 36: Base.InvokeKeys.COMMAND, Line 37: Authz.InvokeCommands.FETCH_PRINCIPAL_RECORD Line 38: ).mput( Line 39: Authn.InvokeKeys.AUTH_RECORD, Line 40: (ExtMap) authRecord > I was in a dilemma whether to expose ExtMap or not. At the end ExtMap should be used all over in bll... it will only make it simpler. Line 41: )).<ExtMap> get(Authz.InvokeKeys.PRINCIPAL_RECORD)); Line 42: } Line 43: Line 44: public static List<DirectoryUser> findPrincipalsByQuery(final ExtensionProxy extension, final String query) { http://gerrit.ovirt.org/#/c/26602/10/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapBrokerCommandBase.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapBrokerCommandBase.java: Line 47: Authn.AuthResult.CREDENTIALS_EXPIRED); Line 48: resultsMap.put(AuthenticationResult.USER_ACCOUNT_DISABLED_OR_LOCKED, Line 49: Authn.AuthResult.ACCOUNT_LOCKED); Line 50: resultsMap.put(AuthenticationResult.WRONG_REALM, Line 51: Authn.AuthResult.CREDENTIALS_INCORRECT); > As the directory implementation uses AuthenticationResult throughout its co ok Line 52: } Line 53: Line 54: private Map<String, LdapGroup> globalGroupsDict = new HashMap<>(); Line 55: -- To view, visit http://gerrit.ovirt.org/26602 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I916012eab61a96bdb0f366d9dc8462325d7f726f Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
