Ravi Nori has posted comments on this change.

Change subject: core, engine, webadmin: Shutdown/power off operations on a VM 
would ask for an optional reason
......................................................................


Patch Set 13:

(1 comment)

http://gerrit.ovirt.org/#/c/25633/13/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java:

Line 72:     private boolean trustedService;
Line 73: 
Line 74:     private boolean haReservation;
Line 75: 
Line 76:     private boolean vmStopReasonRequired;
> I might be missing something here, I am not sure what controls this field, 
>From the RFE https://bugzilla.redhat.com/show_bug.cgi?id=1065753

The optional field for Shutdown/Poweroff VM operations should be configurable 
at the Cluster level. So that is what the patch does.
Line 77: 
Line 78:     private Guid clusterPolicyId;
Line 79: 
Line 80:     private String clusterPolicyName;


-- 
To view, visit http://gerrit.ovirt.org/25633
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I17645e5bc97a1a4d460956ec45f88524465dfd7b
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to