Gilad Chaplik has posted comments on this change. Change subject: core, engine, webadmin: Shutdown/power off operations on a VM would ask for an optional reason ......................................................................
Patch Set 13: (3 comments) -1 on technicality as well, see inline. http://gerrit.ovirt.org/#/c/25633/13/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java: Line 72: private boolean trustedService; Line 73: Line 74: private boolean haReservation; Line 75: Line 76: private boolean vmStopReasonRequired; vmStopReasonRequired isn't a cluster field- that's user configuration, please consult Alex to have it stored in local data (suggestion I gave you in the mailing list). Cluster is irrelevant here. Line 77: Line 78: private Guid clusterPolicyId; Line 79: Line 80: private String clusterPolicyName; http://gerrit.ovirt.org/#/c/25633/13/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java: Line 72: CommentColumn<VM> commentColumn = new CommentColumn<VM>(); Line 73: getTable().addColumnWithHtmlHeader(commentColumn, commentColumn.getHeaderHtml(), "30px"); //$NON-NLS-1$ Line 74: Line 75: ReasonColumn<VM> reasonColumn = new ReasonColumn<VM>(); Line 76: getTable().addColumnWithHtmlHeader(reasonColumn, reasonColumn.getHeaderHtml(), "30px"); //$NON-NLS-1$ No need for another VM tab table column. reuse the same column comment field is using. even a nice icon can be added for that purpose. Line 77: Line 78: TextColumnWithTooltip<VM> hostColumn = new TextColumnWithTooltip<VM>() { Line 79: @Override Line 80: public String getValue(VM object) { http://gerrit.ovirt.org/#/c/25633/13/packaging/dbscripts/vms_sp.sql File packaging/dbscripts/vms_sp.sql: Line 392: SET Line 393: reason = null Line 394: WHERE vm_guid = v_vm_guid; Line 395: END; $procedure$ Line 396: LANGUAGE plpgsql; For clearing you have a separate db flow, why not for adding as well? Line 397: Line 398: Line 399: Line 400: Create or replace FUNCTION DeleteVmDynamic(v_vm_guid UUID) -- To view, visit http://gerrit.ovirt.org/25633 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17645e5bc97a1a4d460956ec45f88524465dfd7b Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
