Gilad Chaplik has posted comments on this change. Change subject: core, engine, webadmin: Shutdown/power off operations on a VM would ask for an optional reason ......................................................................
Patch Set 13: (2 comments) http://gerrit.ovirt.org/#/c/25633/13/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java: Line 72: private boolean trustedService; Line 73: Line 74: private boolean haReservation; Line 75: Line 76: private boolean vmStopReasonRequired; > From the RFE https://bugzilla.redhat.com/show_bug.cgi?id=1065753 That is a misunderstanding of the cluster entity. I'm sorry that you didn't get that from the thread in the mailing list, I think I was pretty clear about that... Even got awels to help you solve that; but you're right, it's always better to do what you were asked :-) Line 77: Line 78: private Guid clusterPolicyId; Line 79: Line 80: private String clusterPolicyName; http://gerrit.ovirt.org/#/c/25633/13/packaging/dbscripts/vms_sp.sql File packaging/dbscripts/vms_sp.sql: Line 392: SET Line 393: reason = null Line 394: WHERE vm_guid = v_vm_guid; Line 395: END; $procedure$ Line 396: LANGUAGE plpgsql; > Hi Gilad, I will explain you what I mean once someone else ask for the same feature in a different context. The patch is already merged, no? Line 397: Line 398: Line 399: Line 400: Create or replace FUNCTION DeleteVmDynamic(v_vm_guid UUID) -- To view, visit http://gerrit.ovirt.org/25633 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17645e5bc97a1a4d460956ec45f88524465dfd7b Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
