Ravi Nori has posted comments on this change. Change subject: core, engine, webadmin: Shutdown/power off operations on a VM would ask for an optional reason ......................................................................
Patch Set 13: (1 comment) http://gerrit.ovirt.org/#/c/25633/13/packaging/dbscripts/vms_sp.sql File packaging/dbscripts/vms_sp.sql: Line 392: SET Line 393: reason = null Line 394: WHERE vm_guid = v_vm_guid; Line 395: END; $procedure$ Line 396: LANGUAGE plpgsql; > For clearing you have a separate db flow, why not for adding as well? Hi Gilad, We are clearing while we are doing RunVm, during Run VM we are not persisting VmDynamic info into the database. So we need a separate call to clear the info from the reason field. We are setting reason field during Shutdown/Poweroff. During both these flows the VmDynamic information is persisted to the database. If I decide to use a separate flow for set reason field in the database, we are making one extra call to the database. I avoided that by modifying the call we are already amking to set the reason field Line 397: Line 398: Line 399: Line 400: Create or replace FUNCTION DeleteVmDynamic(v_vm_guid UUID) -- To view, visit http://gerrit.ovirt.org/25633 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17645e5bc97a1a4d460956ec45f88524465dfd7b Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
