Yair Zaslavsky has posted comments on this change. Change subject: aaa: Change builtin authenticators and directories initialization ......................................................................
Patch Set 9: (3 comments) http://gerrit.ovirt.org/#/c/25741/9/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java: Line 178: getFileName(alreadyLoadedEntry.file)) Line 179: ); Line 180: } Line 181: loadedEntries.put(entry.getName(), entry); Line 182: boolean enabled = > if you added the new flag this was valid... I mean overriding the entry.ena Done Line 183: EngineLocalConfig.getInstance().getBoolean(ENGINE_EXTENSION_ENABLED + entry.getName(), entry.enabled); Line 184: //Activate the extension Line 185: if (enabled && entry.extension == null) { Line 186: try { Line 181: loadedEntries.put(entry.getName(), entry); Line 182: boolean enabled = Line 183: EngineLocalConfig.getInstance().getBoolean(ENGINE_EXTENSION_ENABLED + entry.getName(), entry.enabled); Line 184: //Activate the extension Line 185: if (enabled && entry.extension == null) { > which result in reverting this one as well^ Done Line 186: try { Line 187: entry.extension = (Extension) lookupService( Line 188: Extension.class, Line 189: entry.getConfig().getProperty(CLASS), Line 194: entry.activated = true; Line 195: activatedEntries.put(entry.getName(), entry); Line 196: for (String provides : entry.getProvides()) { Line 197: MultiValueMapUtils.addToMap(provides, entry, providesEntries); Line 198: } > much better is to remove the use of this MultiValueMapUtils which pulls uti well, you still need to have a Map<String,List<ExtensionEntry>> - in previous rounds I did not use this utils class, and you asked if we have something to avoid writing the code that adds a new entry to a "multi map" on my own. Line 199: } catch (Exception ex) { Line 200: log.error( Line 201: String.format( Line 202: "Error in activating extension %1$s. Exception message is %2$s", -- To view, visit http://gerrit.ovirt.org/25741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8513cb992c5becef7e83c04a8da8bc7f1622348 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
