Yair Zaslavsky has posted comments on this change. Change subject: aaa: Change builtin authenticators and directories initialization ......................................................................
Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/25741/8/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java: Line 61: return enabled; Line 62: } Line 63: Line 64: public String getProvides() { Line 65: return (String) context.get(ExtensionProperties.PROVIDES); > .split("[,]") and trim() to support multiple interfaces within single exten Done Line 66: } Line 67: Line 68: public Map<ExtensionProperties, Object> getContext() { Line 69: return context; Line 168: getFileName(alreadyLoadedEntry.file)) Line 169: ); Line 170: } Line 171: loadedEntries.put(entry.getName(), entry); Line 172: entry.enabled = EngineLocalConfig.getInstance().getBoolean(ENGINE_EXTENSION_ENABLED + entry.getName(), entry.enabled); > put this in temp variable and set entry.enabled only if success. why? i do not want to lookupService for extensions that I know that have enabled=false in their configuration. Line 173: //Activate the extension Line 174: if (entry.enabled && entry.extension == null) { Line 175: try { Line 176: entry.extension = (Extension) lookupService( -- To view, visit http://gerrit.ovirt.org/25741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8513cb992c5becef7e83c04a8da8bc7f1622348 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
