Alon Bar-Lev has posted comments on this change. Change subject: aaa: Change builtin authenticators and directories initialization ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/25741/9/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java: Line 194: entry.activated = true; Line 195: activatedEntries.put(entry.getName(), entry); Line 196: for (String provides : entry.getProvides()) { Line 197: MultiValueMapUtils.addToMap(provides, entry, providesEntries); Line 198: } > well, you still need to have a Map<String,List<ExtensionEntry>> - in previo well, I would have dropped this... just iterate via the extension map... there is no need to optimize it. Line 199: } catch (Exception ex) { Line 200: log.error( Line 201: String.format( Line 202: "Error in activating extension %1$s. Exception message is %2$s", -- To view, visit http://gerrit.ovirt.org/25741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8513cb992c5becef7e83c04a8da8bc7f1622348 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
