Alon Bar-Lev has posted comments on this change. Change subject: aaa: Change builtin authenticators and directories initialization ......................................................................
Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/25741/10/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java: Line 202: entry.extension.init(); Line 203: entry.activated = true; Line 204: for (String provides : entry.getProvides()) { Line 205: MultiValueMapUtils.addToMap(provides, entry, providesEntries); Line 206: } have you seen: much better is to remove the use of this MultiValueMapUtils which pulls utils... and use the List::addAll and the other two comments at patch 9 regarding the enabled? Line 207: } catch (Exception ex) { Line 208: log.error( Line 209: String.format( Line 210: "Error in activating extension %1$s. Exception message is %2$s", -- To view, visit http://gerrit.ovirt.org/25741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8513cb992c5becef7e83c04a8da8bc7f1622348 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
