Yair Zaslavsky has posted comments on this change. Change subject: aaa: Change builtin authenticators and directories initialization ......................................................................
Patch Set 5: (6 comments) http://gerrit.ovirt.org/#/c/25741/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java: Line 122: ExtensionsManager.getInstance().load(authConfig); Line 123: Line 124: Properties dirConfig = new Properties(); Line 125: dirConfig.put(ExtensionsManager.CLASS, "org.ovirt.engine.extensions.aaa.builtin.internal.InternalDirectory"); Line 126: dirConfig.put(ExtensionsManager.PROVIDES, "org.ovirt.engine.core.authorization"); > so why it is org.ovirt.engine.core.authorization? I thought we detach from please fix your examples :) i copy/paste from there :) we can define a ProviderTypes class at extensions API with constants for authentication, authorization, etc... what do yo u think? Line 127: dirConfig.put(ExtensionsManager.ENABLED, "true"); Line 128: dirConfig.put(ExtensionsManager.MODULE, "org.ovirt.engine.extensions.builtin"); Line 129: dirConfig.put("config.authz.user.name", Config.<String> getValue(ConfigValues.AdminUser)); Line 130: dirConfig.put(ExtensionsManager.NAME, "builtin-authz-internal"); Line 126: dirConfig.put(ExtensionsManager.PROVIDES, "org.ovirt.engine.core.authorization"); Line 127: dirConfig.put(ExtensionsManager.ENABLED, "true"); Line 128: dirConfig.put(ExtensionsManager.MODULE, "org.ovirt.engine.extensions.builtin"); Line 129: dirConfig.put("config.authz.user.name", Config.<String> getValue(ConfigValues.AdminUser)); Line 130: dirConfig.put(ExtensionsManager.NAME, "builtin-authz-internal"); > up one line :) Done Line 131: dirConfig.put("ovirt.engine.aaa.authz.profile.name", "internal"); Line 132: ExtensionsManager.getInstance().load(dirConfig); Line 133: } Line 134: Line 127: dirConfig.put(ExtensionsManager.ENABLED, "true"); Line 128: dirConfig.put(ExtensionsManager.MODULE, "org.ovirt.engine.extensions.builtin"); Line 129: dirConfig.put("config.authz.user.name", Config.<String> getValue(ConfigValues.AdminUser)); Line 130: dirConfig.put(ExtensionsManager.NAME, "builtin-authz-internal"); Line 131: dirConfig.put("ovirt.engine.aaa.authz.profile.name", "internal"); > Well, I assume that in several directory implementations I will require to done. removed it. Line 132: ExtensionsManager.getInstance().load(dirConfig); Line 133: } Line 134: Line 135: private void createKerberosLdapAAAConfigurations() { Line 153: dirConfig.put(ExtensionsManager.PROVIDES, "org.ovirt.engine.core.authorization"); Line 154: dirConfig.put(ExtensionsManager.ENABLED, "true"); Line 155: dirConfig.put(ExtensionsManager.MODULE, "org.ovirt.engine.extensions.builtin"); Line 156: dirConfig.put(ExtensionsManager.NAME, String.format("builtin-authz-%1$s", domain)); Line 157: dirConfig.put("ovirt.engine.aaa.authz.profile.name", domain); > again... I do not think that this^ is required. Done Line 158: ExtensionsManager.getInstance().load(dirConfig); Line 159: } Line 160: } Line 161: http://gerrit.ovirt.org/#/c/25741/5/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java: Line 142: ExtensionEntry entry = new ExtensionEntry(props, confFile); Line 143: ExtensionEntry alreadyLoaded = loadedEntries.get(entry.getName()); Line 144: if (alreadyLoaded != null) { Line 145: throw new ConfigurationException(String.format("Could not load the configuration %1$s. %2$s", Line 146: String.format("'%1$s' %2$s", entry.getName(), entry.file != null ? "from file " + entry.file.getAbsolutePath(): ""), > please indent.... i simplified. Line 147: alreadyLoaded.file != null ? String.format("The already loaded file %1$s contains a configuration with the same name", Line 148: alreadyLoaded.file.getAbsolutePath()) Line 149: : "")); Line 150: } Line 246: } Line 247: } Line 248: } Line 249: Line 250: public void logEnabledExtensions() { > dump() ? :) Done Line 251: log.info("Start of enabled extensions list"); Line 252: for (ExtensionEntry entry: loadedEntries.values()) { Line 253: if (entry.extension != null) { Line 254: Map<ExtensionProperties, Object> context = entry.extension.getContext(); -- To view, visit http://gerrit.ovirt.org/25741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8513cb992c5becef7e83c04a8da8bc7f1622348 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
