Alon Bar-Lev has posted comments on this change. Change subject: aaa: Change builtin authenticators and directories initialization ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/25741/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java: Line 122: ExtensionsManager.getInstance().load(authConfig); Line 123: Line 124: Properties dirConfig = new Properties(); Line 125: dirConfig.put(ExtensionsManager.CLASS, "org.ovirt.engine.extensions.aaa.builtin.internal.InternalDirectory"); Line 126: dirConfig.put(ExtensionsManager.PROVIDES, "org.ovirt.engine.core.authorization"); > PROVIDES hold entry of autheorization/authentication, didn't understand you so why it is org.ovirt.engine.core.authorization? I thought we detach from engine naming. we should define several interfaces which are public ones. Line 127: dirConfig.put(ExtensionsManager.ENABLED, "true"); Line 128: dirConfig.put(ExtensionsManager.MODULE, "org.ovirt.engine.extensions.builtin"); Line 129: dirConfig.put("config.authz.user.name", Config.<String> getValue(ConfigValues.AdminUser)); Line 130: dirConfig.put(ExtensionsManager.NAME, "builtin-authz-internal"); Line 126: dirConfig.put(ExtensionsManager.PROVIDES, "org.ovirt.engine.core.authorization"); Line 127: dirConfig.put(ExtensionsManager.ENABLED, "true"); Line 128: dirConfig.put(ExtensionsManager.MODULE, "org.ovirt.engine.extensions.builtin"); Line 129: dirConfig.put("config.authz.user.name", Config.<String> getValue(ConfigValues.AdminUser)); Line 130: dirConfig.put(ExtensionsManager.NAME, "builtin-authz-internal"); > not sure i understood what to move up. up one line :) Line 131: dirConfig.put("ovirt.engine.aaa.authz.profile.name", "internal"); Line 132: ExtensionsManager.getInstance().load(dirConfig); Line 133: } Line 134: -- To view, visit http://gerrit.ovirt.org/25741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8513cb992c5becef7e83c04a8da8bc7f1622348 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
