Alon Bar-Lev has posted comments on this change. Change subject: aaa: Change builtin authenticators and directories initialization ......................................................................
Patch Set 2: (4 comments) http://gerrit.ovirt.org/#/c/25741/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java: Line 116: authConfig.put(ExtensionManager.NAME, "builtin-authn-internal"); Line 117: authConfig.put("ovirt.engine.aaa.authn.profile.name", "internal"); Line 118: authConfig.put("ovirt.engine.aaa.authn.authz.plugin", "builtin-authz-internal"); Line 119: authConfig.put("ovirt.engine.aaa.authn.user", Config.<String> getValue(ConfigValues.AdminUser)); Line 120: authConfig.put("ovirt.engine.aaa.authn.password", Config.<String> getValue(ConfigValues.AdminPassword)); > please also provide a usage example for the new key of sensitive-keys - is ovirt.engine.extension.config.sensitiveKeys = config.authn.user.password, config.authn.user.password1, config.authn.user.password2 Line 121: results.add(authConfig); Line 122: Line 123: Properties dirConfig = new Properties(); Line 124: dirConfig.put(ExtensionManager.CLASS, "org.ovirt.engine.extensions.aaa.builtin.internal.InternalDirectory"); http://gerrit.ovirt.org/#/c/25741/2/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalDirectory.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalDirectory.java: Line 32 Line 33 Line 34 Line 35 Line 36 > + I can add code at initOnStartup that will fetch from the db the internal ok... you get the internal internal id which will map to admin at bll and put in configuration. http://gerrit.ovirt.org/#/c/25741/2/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionManager.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionManager.java: please rename class to ExtensionsManager or rename module to extension-manager. Line 1: package org.ovirt.engine.core.extensions.mgr; Line 2: Line 3: import static java.util.Arrays.sort; Line 4: Line 233: for (ExtensionEntry entry : loadedEntries.values()) { Line 234: //Engine local config might override the enabled property of the configuration Line 235: // if a proper entry exists at the engine config. Line 236: entry.enabled = config.getBoolean(ENGINE_EXTENSION_ENABLED + entry.getName(), entry.enabled); Line 237: if (entry.enabled && entry.extension == null) { > and where will activate be called? will it be called from the two public lo we need to protect the load not between loads. so if: load1(file)->load2(properties)->actually messes with maps you need to synchronize only load2. Line 238: try { Line 239: entry.extension = (Extension) lookupService( Line 240: Extension.class, Line 241: entry.getConfig().getProperty(CLASS), -- To view, visit http://gerrit.ovirt.org/25741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8513cb992c5becef7e83c04a8da8bc7f1622348 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
