Yair Zaslavsky has posted comments on this change. Change subject: aaa: Removal of authenticator classes ......................................................................
Patch Set 2: I am not that fan of having bitwise arithmetics if not mandatory in Java. But let's assume we go for it - do you want to have on the context an integer value let's called AAA_AUTHENTICATION_TYPES ? I would still like to have boolean helper methods like isPasswordAuth() that will perform: return context.get(ExtensionKeys.AAA_AUTHENTICATION_TYPES) & AAA_PASSWORD_AUTHENTICATION_FLAG) ? Regarding the 2nd comment - if the authenticator does not support password authentication in login base command, you will get an error. if there is no authentication filter that supports negotiation, we simply continue in the filter chain. Am I missing something? -- To view, visit http://gerrit.ovirt.org/25571 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3a6f8586bdb14fcc6c09c77dc1b761b795fce07 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
