Alon Bar-Lev has posted comments on this change. Change subject: aaa: Removal of authenticator classes ......................................................................
Patch Set 2: (1 comment) Can I be very peaky?!? I prefer authenticator flags, or based constants... so we have only one in environment and ask via bitwise and. This will enable adding more flags without adding new attributes. Also... please notice that you need to handle the state in which neither is set... I hope you tested this. http://gerrit.ovirt.org/#/c/25571/2/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/Authenticator.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/Authenticator.java: Line 86: } Line 87: Line 88: public boolean isNegotiationAuth() { Line 89: return context.get(ExtensionProperties.AAA_IS_NEGOTIATION_AUTH) != null ? (Boolean) context.get(ExtensionProperties.AAA_IS_NEGOTIATION_AUTH) Line 90: : false; nobody in java thoughts of get with default! Line 91: } Line 92: Line 93: public boolean isPasswordAuth() { Line 94: return context.get(ExtensionProperties.AAA_IS_NEGOTIATION_AUTH) != null ? (Boolean) context.get(ExtensionProperties.AAA_IS_PASSWORD_AUTH) -- To view, visit http://gerrit.ovirt.org/25571 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3a6f8586bdb14fcc6c09c77dc1b761b795fce07 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
