Alon Bar-Lev has posted comments on this change. Change subject: tools: Adds bash completion for engine-manage-domains ......................................................................
Patch Set 1: Code-Review-1 although I appreciate your push toward parameters etc... I do not think we as upstream should provide bash specific, nor do we need extra dependency in spec. the manage domains is not that usable for people not to read the usage and act upon. also, th manage domains utility is soon to be gone. and anyway, if we add support for bash completion, we should be consistent and add it for all... but please don't go this route. This is my take, adding some more people. thanks! -- To view, visit http://gerrit.ovirt.org/24483 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66d9733d9a4e380e40a457370f08483d832527c1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
