Alon Bar-Lev has posted comments on this change. Change subject: tools: Adds bash completion for engine-manage-domains ......................................................................
Patch Set 1: anyway for this reference... completions of product should go into: /usr/share/bash-completion/completions/ and not into /etc, as in rhel the setting is wrongly in /etc, the make should get a parameter of BASH_COMPLETION_DIR= that is set at spec to correct location. Also, the Makefile should allow to enable/disable this installation to allow customizing this feature if not required. -- To view, visit http://gerrit.ovirt.org/24483 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66d9733d9a4e380e40a457370f08483d832527c1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
