Yaniv Dary has posted comments on this change. Change subject: packaging: using patches to customize war instead of overwrites ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/24275/4/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py: Line 812: rc, stdout, stderr = self.execute( Line 813: args=( Line 814: self.command.get('patch'), Line 815: '-p1', Line 816: '-B', self._patchesbackup, > not sure why do you need it within self... just put the os.path.join here Done Line 817: '-d', ( Line 818: oreportscons.FileLocations. Line 819: OVIRT_ENGINE_REPORTS_JASPER_WAR Line 820: ) -- To view, visit http://gerrit.ovirt.org/24275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0becc8ef9206fa077547682fd4c299fa5491b15 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
