Yaniv Dary has posted comments on this change. Change subject: packaging: using patches to customize war instead of overwrites ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/24275/1/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py: Line 796: Line 797: self.logger.info(_('Customizing Jasper')) Line 798: Line 799: base = oreportscons.FileLocations.OVIRT_ENGINE_WAR_PATCHES Line 800: for directory, dirs, files in os.walk(base): > Perhaps glob.glob(os.path.join(path, '*.patch')) ? And rename change-login- Done Line 801: for p in files: Line 802: rc, stdout, stderr = self.execute( Line 803: args=( Line 804: '/usr/bin/patch', Line 802: rc, stdout, stderr = self.execute( Line 803: args=( Line 804: '/usr/bin/patch', Line 805: '-p2', Line 806: '<', > perhaps '-i' ? Done Line 807: os.path.join( Line 808: directory, Line 809: p, Line 810: ), -- To view, visit http://gerrit.ovirt.org/24275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0becc8ef9206fa077547682fd4c299fa5491b15 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
