Juan Hernandez has posted comments on this change. Change subject: codegen: Only top level elements in root class map ......................................................................
Patch Set 3: Verified+1 The new patch set modifies the existing class map so that the value will be a list of classes, instead of just one. This handles the case where multiple types correspond to the same element name. The method "findRootClass" is preserved, but it will always return the first element in the list. A new "findRootClasses" method has been added that returns the list. An additional map is created that contains only the root elements, and this is the one used by the code generator. In addition to solve the conflict with the "nics" element this also solves the previously existing conflicts with VersionCaps. -- To view, visit http://gerrit.ovirt.org/23964 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcdefe71f3d15ab0da841f35b4b94916d19d950d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8...@yahoo.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
