Michael Pasternak has posted comments on this change. Change subject: codegen: Only top level elements in root class map ......................................................................
Patch Set 3: Juan, This is indeed a step towards insertion of types with same element_name to the cache, however it does not solve retrieval of the right type from the cache not for humans nor for machine as getXmlType(type_name) will always return the first type in the list of types stored under same element_name key, what you did is rootClasses<element_name,[types]> what has to be done in order for this to work is: rootClasses<element_name,<outer_element_name, type>> i.e context aware cache, but if you ask me - this is a long term task, for now i'd just address ambiguous element name in the RES-API schema. -- To view, visit http://gerrit.ovirt.org/23964 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcdefe71f3d15ab0da841f35b4b94916d19d950d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8...@yahoo.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
