Daniel Erez has posted comments on this change. Change subject: engine, dao: Introduce ISCSI Bond entity, tables and dao ......................................................................
Patch Set 9: (3 comments) http://gerrit.ovirt.org/#/c/22951/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetIscsiBondsByStoragePoolIdQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetIscsiBondsByStoragePoolIdQuery.java: Line 16: @Override Line 17: protected void executeQueryCommand() { Line 18: List<IscsiBond> iscsiBonds = getDbFacade().getIscsiBondDao().getAllByStoragePoolId(getParameters().getId()); Line 19: Line 20: for (IscsiBond iscsiBond : iscsiBonds) { could it be done in a single query with all needed network/connection (for optimization)? Line 21: List<Guid> networkIds = getDbFacade().getIscsiBondDao().getNetworkIdsByIscsiBondId(iscsiBond.getId()); Line 22: iscsiBond.setNetworkIds(networkIds); Line 23: Line 24: List<String> connectionIds = getDbFacade().getIscsiBondDao().getStorageConnectionIdsByIscsiBondId(iscsiBond.getId()); http://gerrit.ovirt.org/#/c/22951/9/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IscsiBond.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IscsiBond.java: Line 108: int result = 1; Line 109: result = prime * result + ((id == null) ? 0 : id.hashCode()); Line 110: result = prime * result + ((name == null) ? 0 : name.hashCode()); Line 111: result = prime * result + ((description == null) ? 0 : description.hashCode()); Line 112: result = prime * result + ((storagePoolId == null) ? 0 : storagePoolId.hashCode()); what about networkIds and storageConnectionIds ? Line 113: return result; Line 114: } Line 115: Line 116: @Override Line 123: return false; Line 124: } Line 125: Line 126: IscsiBond iscsiBond = (IscsiBond) obj; Line 127: return ObjectUtils.objectsEqual(id, iscsiBond.getId()) && same Line 128: ObjectUtils.objectsEqual(name, iscsiBond.getName()) && Line 129: ObjectUtils.objectsEqual(description, iscsiBond.getDescription()) && Line 130: ObjectUtils.objectsEqual(storagePoolId, iscsiBond.getStoragePoolId()); Line 131: } -- To view, visit http://gerrit.ovirt.org/22951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12313c02810a2f0e75016bdd78b44da43f2154d4 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
