Maor Lipchuk has posted comments on this change. Change subject: engine, dao: Introduce ISCSI Bond entity, tables and dao ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/22951/11/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IscsiBond.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IscsiBond.java: Line 131: ObjectUtils.objectsEqual(name, iscsiBond.getName()) && Line 132: ObjectUtils.objectsEqual(description, iscsiBond.getDescription()) && Line 133: ObjectUtils.objectsEqual(storagePoolId, iscsiBond.getStoragePoolId()) && Line 134: ObjectUtils.objectsEqual(networkIds, iscsiBond.getNetworkIds()) && Line 135: ObjectUtils.objectsEqual(storageConnectionIds, iscsiBond.getStorageConnectionIds()); I added a respond to Daniel on this issue in patch set 9. Can you please explain why do you need to check equals and hashcode on those lists? Those lists are transient and could not be fetched from the DB... Putting those lists on equlas and hashcode seems irrelevant, the lists will always be empty when fetching it from the DB, it will only be prone error for the DAO tests IMHO? Line 136: } -- To view, visit http://gerrit.ovirt.org/22951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12313c02810a2f0e75016bdd78b44da43f2154d4 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amador Pahim <apa...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
