Maor Lipchuk has posted comments on this change. Change subject: engine, dao: Introduce ISCSI Bond entity, tables and dao ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/22951/6/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/IscsiBondDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/IscsiBondDaoTest.java: Line 28: dao = dbFacade.getIscsiBondDao(); Line 29: storagePoolId = new Guid("6d849ebf-755f-4552-ad09-9a090cda105d"); Line 30: iscsiBondId = new Guid("7368f2be-1263-41f8-b95e-70cdaf23b80d"); Line 31: networkId = new Guid("58d5c1c6-cb15-4832-b2a4-023770607190"); Line 32: connectionId = "0cc146e8-e5ed-482c-8814-270bc48c297e"; > I am using these Guids internally for my tests, why put them there? because it would be much more readable. Take storagePoolId for example, you don't have to declare it here, just use : FixturesTool.STORAGE_POOL_RHEL6_ISCSI_OTHER Line 33: Line 34: newIscsiBond = new IscsiBond(); Line 35: newIscsiBond.setId(Guid.newGuid()); Line 36: newIscsiBond.setName("Multipath"); -- To view, visit http://gerrit.ovirt.org/22951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12313c02810a2f0e75016bdd78b44da43f2154d4 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
